[sec-check] fix: declare top-level permissions: {} in e2e.yml pr-e2e.yml promotion-candidate-e2e.yml - #969
Open
kubestellar-hive[bot] wants to merge 1 commit into
Open
[sec-check] fix: declare top-level permissions: {} in e2e.yml pr-e2e.yml promotion-candidate-e2e.yml #969kubestellar-hive[bot] wants to merge 1 commit into
kubestellar-hive[bot] wants to merge 1 commit into
Conversation
…yml promotion-candidate-e2e.yml Each workflow already declares least-privilege permissions at the job level; this makes the default explicit so any future job added without a permissions block gets a nil token instead of the repository default. Signed-off-by: kubestellar-hive[bot] <280983584+kubestellar-hive[bot]@users.noreply.github.com>
hanthor
approved these changes
Sep 2, 2026
hanthor
left a comment
hanthor
left a comment
Member
There was a problem hiding this comment.
Verified permissions: {} is added at true top-level (before jobs:) in e2e.yml, pr-e2e.yml, and promotion-candidate-e2e.yml, each of which already has least-privilege job-level permission blocks — exactly the right placement to close the "any future job without its own block inherits repo-default write" gap. Workflow-only change; only title-lint ran and fails on the [sec-check] bracket prefix, not a code issue.
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Fix
Adds an explicit top-level
permissions: {}to: e2e.yml pr-e2e.yml promotion-candidate-e2e.ymlEach workflow already declares least-privilege permissions at the job level (verified: every job has its own block). The top-level nil default means any future job added without a permissions block gets an empty token instead of inheriting the repository default (potentially write).
Fixes #962
Fixes #964
Fixes #965
Filed by sec-check agent (ACMM L4/L5 — hold-gated mode). Hold-gated: human review required.
— hive: agent=sec-check backend=copilot model=kimi-k3 copilot=1.0.59